Open
Conversation
shazron
approved these changes
Apr 25, 2024
moritzraho
approved these changes
Apr 25, 2024
MichaelGoberling
approved these changes
Apr 25, 2024
Member
|
tests are now failing |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the environment variable storage to upcase all keys before they are saved in the .env file.
- Changed the mapping in src/lib/import-helper.js to convert keys to uppercase.
- Aims to prevent issues with invalid identifier characters in .env keys.
Comments suppressed due to low confidence (1)
src/lib/import-helper.js:416
- [nitpick] Consider adding unit tests to verify that all keys are correctly upcased, ensuring that fixture updates won't introduce side effects once tests are updated.
.map(key => `${key.toUpperCase()}=${resultObject[key]}`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Confusing lowercase .env keys adobe/aio-cli
I have not updated the tests as this really just means upcasing all the fixtures and I want to be sure there are no unexpected side-effects before heavy handedly making the tests pass.
Motivation and Context
I was confused ... I still am about this key:
AIO_ims_contexts_Credential__in__Jesse__Is__Back__-__Stage_client__id-is not valid in an identifier/property name, so this becomes:( note the ticks )
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: